Skip to content

Add support for multi-phase module initialization#485

Merged
stefanseefeld merged 5 commits into
boostorg:developfrom
o01eg:multi-phase-module-init
Jun 21, 2026
Merged

Add support for multi-phase module initialization#485
stefanseefeld merged 5 commits into
boostorg:developfrom
o01eg:multi-phase-module-init

Conversation

@o01eg

@o01eg o01eg commented Apr 20, 2025

Copy link
Copy Markdown
Contributor

Fixes #484

@o01eg

o01eg commented May 11, 2025

Copy link
Copy Markdown
Contributor Author

I only unsure if Py_mod_create should be accessible and defined too.

@o01eg

o01eg commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

Ping!

@o01eg o01eg marked this pull request as draft April 4, 2026 14:25
@o01eg

o01eg commented Apr 4, 2026

Copy link
Copy Markdown
Contributor Author

It's quite bad that nogil support was added only to single-phase initialization

@o01eg o01eg force-pushed the multi-phase-module-init branch from 957157e to 40105f0 Compare April 4, 2026 18:59
@o01eg o01eg marked this pull request as ready for review April 4, 2026 19:00
@o01eg

o01eg commented Apr 4, 2026

Copy link
Copy Markdown
Contributor Author

Ping! I need an approval.

@o01eg

o01eg commented Apr 5, 2026

Copy link
Copy Markdown
Contributor Author

Looks like Windows CI is broken not by my changes:

  A suitable version of 7zip was not found (required v21.7.0). Downloading portable 7zip v21.7.0...
  Downloading 7zip...
    https://www.7-zip.org/a/7z2107-extra.7z -> D:\a\python\vcpkg\downloads\7z2107-extra.7z
  Error: Failed to download from mirror set:
  https://www.7-zip.org/a/7z2107-extra.7z: failed: status code 404

What I see on https://www.7-zip.org/download.html there no such version.

@o01eg o01eg force-pushed the multi-phase-module-init branch from b43199f to 542974f Compare April 5, 2026 13:13
@o01eg

o01eg commented Apr 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've removed unsuccessful try to fix Windows CI. At least other OS passed.

@stefanseefeld

stefanseefeld commented Jun 21, 2026

Copy link
Copy Markdown
Member

hi @o01eg , please rebase this PR as we just fixed the Windows CI builds. Then we should be able to merge this quickly. Thanks !

@o01eg o01eg force-pushed the multi-phase-module-init branch from 542974f to 439ab0d Compare June 21, 2026 19:52
@o01eg

o01eg commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@stefanseefeld I've rebased it.

@stefanseefeld stefanseefeld merged commit 97a623d into boostorg:develop Jun 21, 2026
@stefanseefeld

stefanseefeld commented Jun 21, 2026

Copy link
Copy Markdown
Member

Thank you !

@o01eg o01eg deleted the multi-phase-module-init branch June 21, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for multi-phase module initialization with PyModule_FromDefAndSpec

2 participants

@o01eg @stefanseefeld